Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Fixed Issue #1172: Discard button now reverts textValue.text to original string value #1224

Closed
wants to merge 3 commits into from

Conversation

KrisRJack
Copy link
Contributor

Fixes #1172

Fixed issue that prevented Discard observer from undoing changes.

Testing and Review Notes

Open app and edit a Login Record. Change the Username field or Password field. Click Cancel and discard changes. Changes should no longer be viewable.

To Do

  • add “WIP” to the PR title if pushing up but not complete nor ready for review
  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • add unit tests
    • optional: consider adding integration tests (UI specs)
  • consider running this branch in the simulator and check for warnings
  • request the "UX" team perform a design review (if/when applicable)
  • make sure CI builds are passing (e.g.: fix lint and other errors)

@KrisRJack KrisRJack requested a review from a team as a code owner May 17, 2020 13:28
@KrisRJack KrisRJack closed this May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entry is not updated correctly when editted changes are discarded
1 participant