Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Fix navbar on edit screen #1058

Merged
merged 8 commits into from
Jul 3, 2019
Merged

Fix navbar on edit screen #1058

merged 8 commits into from
Jul 3, 2019

Conversation

joeyg
Copy link
Contributor

@joeyg joeyg commented Jun 16, 2019 •
edited
Loading

This is a PR against the edit-layout screen branch (Details here) It fixes two issues with the navbar:

  • Changing the text from "Edit" to "Save" resulted in the text not fitting in the UIBarButtonItem. sizeToFit() needed to be called to resize the button.
  • The "Cancel" button still have the back arrow "<"

@joeyg joeyg requested a review from a team as a code owner June 16, 2019 19:45
sashei
sashei approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@sashei sashei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests for the image would be cool, but otherwise this looks good to me :)

@joeyg joeyg requested review from a team June 28, 2019 01:25
@devinreams devinreams removed request for a team June 28, 2019 21:26
@devinreams devinreams mentioned this pull request Jul 3, 2019
Closed
@devinreams devinreams merged commit 689e13d into 937-edit-layout-jg Jul 3, 2019
@devinreams devinreams deleted the edit-navbar branch July 3, 2019 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devinreams devinreams devinreams requested changes

@sashei sashei sashei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joeyg @devinreams @sashei