Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update python dep to avoid security vuln #200

Closed
wants to merge 1 commit into from
Closed

Conversation

cmharlow
Copy link
Contributor

Refractr PR Checklist

JIRA ticket: came up in context of https://mozilla-hub.atlassian.net/browse/SE-2688

All this PR does is update 1 python package - aiohttp - to handle a minor dependabot-noted security vulnerability.

Have tested it locally with doit workflow & looks fine.

@cmharlow cmharlow requested a review from a team October 14, 2021 22:23
Copy link
Contributor

@floatingatoll floatingatoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I freely admit my confusion about how this ever worked with .post0 there, but certainly this change is structurally appropriate.

@cmharlow
Copy link
Contributor Author

Notes for the change, which is technically a rollback of the aiohttp package (but one that makes Dependabot happy).

See https://pypi.org/project/aiohttp/#history & aio-libs/aiohttp#5366

Looks like the .post0 addition to the latest stable release is just a packaging fix & not anything to do with the security issue.

Copy link
Contributor

@floatingatoll floatingatoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we looked into this further, and 3.7.4.post0 is newer than 3.7.4 — it's a packaging fix for a third-party dependency. We should stay at .post0. I can still r+ if that's best, but I would prefer to tell Dependabot "no you're wrong" and leave it here.

@cmharlow cmharlow closed this Oct 14, 2021
@cmharlow cmharlow deleted the deps-update-202110 branch October 14, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants