Store the HRIS timezone without modification [IAM-989] #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floatingatoll
force-pushed
the
iam-989
branch
from
77f5f79 to
7938037
Compare
gcoxmoz
reviewed
Nov 9, 2022
gcoxmoz
left a comment
gcoxmoz
left a comment
There was a problem hiding this comment.
All users in the workday report have a Time_Zone (so we're into edge-cases) but, what if they don't.
If Time_Zone were ever missing, in the old world the .get would ship through tz_convert and be collapsed into string "UTC+0000 Europe/London". Now the timezone.value will be (I presume) pythonic None instead of a string.
You might want to make .get() have a UTC-ish default (nitpick, the old default of Europe/London isn't wholly UTC because of BST) or an empty string.
floatingatoll
force-pushed
the
iam-989
branch
from
7938037 to
548e0f6
Compare
Contributor
Author
|
The CIS profile supports value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in IAM-989, we aren't syncing timezones for a lot of workers due to their absence from
tz_convert's manual table. IAM-992 removed the only instance of anyone parsing the timezone field, so this updates the HRIS publisher to just copy the Workday-provided timezone into the record without modification. This can be reversed later on if necessary.