WIP: Remove breaking and deprecated packages to update tests #550
Conversation
✅ Deploy Preview for firefox-performance-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| "babel-loader": "^9.2.1", | ||
| "babel-preset-jest": "^29.6.3", | ||
| "codecov": "3.7.2", | ||
| "cross-fetch": "^4.1.0", |
There was a problem hiding this comment.
FWIW in the profiler server, we were using node-fetch, this was working fine.
But we could remove it after the upgrade to node v22 which supports fetch natively by default.
There was a problem hiding this comment.
Yes, node-fetch isn't working some other dependencies apparently. It's a mess.
| const fetchPromise = fetch(url); | ||
| try { | ||
| // Fetch and store the response in cache | ||
| const fetchPromise = fetch(url).then((res) => { |
There was a problem hiding this comment.
if you want to use await, you might as well use it here as well :-)
| ], | ||
| }, | ||
| transformIgnorePatterns: [ | ||
| '/node_modules/(?!(taskcluster-client-web|data-uri-to-buffer|fetch-blob|formdata-polyfill|cross-fetch)/)', |
There was a problem hiding this comment.
IIRC these ones were used in perfcompare especially because of the taskcluster client, it may not be needed here (or maybe not for all these entries?)
There was a problem hiding this comment.
Yes, I was a bit tired when I did this so thanks for catching this. Some cleanup is definitely needed.
2 participants
Tests will fail.