Improve typescript typing #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the new RenderFn type which all renders now are based on. The signature is: RenderFn<DataProps, Config>: JSX.Element Alongside, to maintain compatibility with previous renders, we introduce the RenderFnWithoutData, which does not receive any data prop. It's the case of delimiter renderer. No existing tests were touch to maintain backward compatibility.
lightningspirit
force-pushed
the
improve-typescript-typing
branch
from
43c1346 to
0b27de0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the new RenderFn type which all renders are now based on.
The signature is:
RenderFn<DataProps, Config>: JSX.ElementWhere:
DataPropsis the object ofdataattribute orundefinedin the case of blocks without data.Configcan beundefinedor an object of extra configs passed to renderers.No tests were touch to maintain backward compatibility.
Closes #13