-
-
Notifications
You must be signed in to change notification settings - Fork 69
feat: Grant additional access for Groups & Recocile logic for masterRole Changes & Metrics Support #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tkcontiant
wants to merge
40
commits into
movetokube:master
Choose a base branch
from
tkcontiant:feat/support-sequences-and-functions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Grant additional access for Groups & Recocile logic for masterRole Changes & Metrics Support #253
tkcontiant
wants to merge
40
commits into
movetokube:master
from
tkcontiant:feat/support-sequences-and-functions
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reload when secret changed
Co-authored-by: Pieter C <pieter@buca.be>
c680836
to
6b789fe
Compare
pcallewaert
reviewed
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I like all these improvements. Some feedback added.
Co-authored-by: Pieter C <pieter@buca.be>
1469980
to
738f725
Compare
2216b8c
to
d590544
Compare
Thanks for the review. I believe we are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I notice we are missing sequences and functions access.
The Second Writer-Group should have limited access to Sequences and execute the Functions.
Reader-Group remains the same
Update Owner-Group if the masterRole was renamed or changed
Re-assign the user group membership
Leader election
PodMonitor
Added for Prometheus Operator Discovery
PodMonitor
Enable Metrics