Skip to content

Conversation

Farfaday
Copy link

Hi,
this MR:

  • add the possibility to set revisionHistoryLimit in the deployment, but keeping the default value to kubernete's default, thus making this change transparent
  • add missing "resources" block into the deployment (defined in values.yaml but missing in the deployment)

Thanks!

@pcallewaert pcallewaert self-assigned this May 13, 2025
@pcallewaert pcallewaert added this to the 2.0 milestone May 13, 2025
Copy link
Contributor

@pcallewaert pcallewaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you remove the version bump? I'll create a separate PR to make a new helm chart release, as there is a breaking change in main currently

@Farfaday
Copy link
Author

Hi @pcallewaert
I removed the version Bump :)
Thanks!

Farfaday added 2 commits May 19, 2025 15:30
Signed-off-by: François Blondel <francois.blondel@diva-e.com>
@pcallewaert pcallewaert merged commit f5755b9 into movetokube:master May 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants