Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

[move-book and move-book-zh] Fix zh translation #465

Closed
wants to merge 5 commits into from
Closed

[move-book and move-book-zh] Fix zh translation #465

wants to merge 5 commits into from

Conversation

Kusou1
Copy link
Contributor

@Kusou1 Kusou1 commented Sep 9, 2022 •
edited
Loading

Motivation

There are also some small mistakes left over from before,i correct them

Have you read the Contributing Guidelines on pull requests?

Yes

@Kusou1 Kusou1 changed the title Fix zh translation [move-book and move-book-zh] Fix zh translation Sep 9, 2022
Kusou1
Kusou1 commented Sep 9, 2022
View reviewed changes
Copy link
Contributor Author

@Kusou1 Kusou1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

@Kusou1
Copy link
Contributor Author

Kusou1 commented Sep 9, 2022

@sblackshear

geometryolife
geometryolife reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@geometryolife geometryolife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already review

Kusou1
Kusou1 commented Sep 9, 2022
View reviewed changes
Copy link
Contributor Author

@Kusou1 Kusou1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

sblackshear
sblackshear approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@sblackshear sblackshear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some merge conflicts need to be fixed

@geometryolife geometryolife mentioned this pull request Oct 5, 2022
Merged
sblackshear pushed a commit that referenced this pull request Oct 7, 2022
@geometryolife @Kusou11
Fix conflict [move-book and move-book-zh] Fix zh translation #465 (#543)
10e921d 
* fix zh Translation

* fix

* fix space

* fix img reference

* make it more desirable

Co-authored-by: shaohong <shaohong.zhang@aigens.com>
@wrwg
Copy link
Member

wrwg commented Oct 17, 2022

Can you please resolve the conflicts and re-submit?

@Kusou1
Copy link
Contributor Author

Kusou1 commented Oct 18, 2022

Can you please resolve the conflicts and re-submit?

ok,i will resolve the conflicts

@geometryolife
Copy link
Contributor

geometryolife commented Oct 18, 2022 •
edited
Loading

Can you please resolve the conflicts and re-submit?

ok,i will resolve the conflicts

I've fixed this and it's already been merged into the main branch in #543
This PR should be closed.
@wrwg @Kusou1

@sblackshear sblackshear closed this Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@geometryolife geometryolife geometryolife left review comments

@sblackshear sblackshear sblackshear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kusou1 @wrwg @geometryolife @sblackshear @Kusou11