Integral retrospective correction

.gitignore

@@ -22,7 +22,6 @@ xcuserdata
 *.moved-aside
 *.xcuserstate
 *.xcscmblueprint
-project.xcworkspace
 
 ## Obj-C/Swift specific
 *.hmap
@@ -55,7 +54,7 @@ Carthage/
 
 # fastlane
 #
-# It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the 
+# It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the
 # screenshots whenever they are needed.
 # For more information about the recommended setup visit:
 # https://github.com/fastlane/fastlane/blob/master/docs/Gitignore.md
@@ -71,3 +70,7 @@ RemoteSettings.plist
 
 # Framework development
 Loop.xcworkspace
+
+# Avoid checking in built assets
+Loop/DerivedAssets.xcassets/
+WatchApp/DerivedAssets.xcassets/

.travis.yml

@@ -1,5 +1,5 @@
 language: objective-c
-osx_image: xcode10.2
+osx_image: xcode11
 # xcode_sdk: iphonesimulator11
 # xcode_project: Loop.xcodeproj
 # xcode_scheme: Loop
@@ -17,5 +17,5 @@ script:
     - set -o pipefail && xcodebuild -project Loop.xcodeproj -scheme Loop build CODE_SIGN_IDENTITY="" CODE_SIGNING_ALLOWED=NO | xcpretty
     - set -o pipefail && xcodebuild -project Loop.xcodeproj -scheme Learn build CODE_SIGN_IDENTITY="" CODE_SIGNING_ALLOWED=NO | xcpretty
     # Run the test target
-    - set -o pipefail && xcodebuild -project Loop.xcodeproj -scheme LoopTests -destination 'name=iPhone SE' test | xcpretty
-    - set -o pipefail && xcodebuild -project Loop.xcodeproj -scheme DoseMathTests -destination 'name=iPhone SE' test | xcpretty
+    - set -o pipefail && xcodebuild -project Loop.xcodeproj -scheme LoopTests -destination 'name=iPhone 8' test | xcpretty
+    - set -o pipefail && xcodebuild -project Loop.xcodeproj -scheme DoseMathTests -destination 'name=iPhone 8' test | xcpretty

Cartfile

@@ -1,8 +1,7 @@
 github "LoopKit/LoopKit" "dev"
 github "LoopKit/CGMBLEKit" "dev"
+github "i-schuetz/SwiftCharts" == 0.6.5
 github "LoopKit/dexcom-share-client-swift" "dev"
 github "LoopKit/G4ShareSpy" "dev"
 github "ps2/rileylink_ios" "dev"
-github "i-schuetz/SwiftCharts" == 0.6.5
 github "LoopKit/Amplitude-iOS" "decreepify"
-github "maxkonovalov/MKRingProgressView" ~> 2.2

Cartfile.resolved

@@ -1,8 +1,8 @@
 github "LoopKit/Amplitude-iOS" "2137d5fd44bf630ed33e1e72d7af6d8f8612f270"
-github "LoopKit/CGMBLEKit" "ea1267791c66e884f1013fffd36faf4555cc6eaf"
-github "LoopKit/G4ShareSpy" "fed5a389e3e47e3a1953878dd21852aa5f44b360"
-github "LoopKit/LoopKit" "e386a24577244ee6b2add52e8b2aff0385c2200b"
-github "LoopKit/dexcom-share-client-swift" "b0419edf55c7f389b36cb47dd5c376bbd3d03d69"
+github "LoopKit/CGMBLEKit" "7b4c1022eb6b91ae3975bfc8ce93fde8e496b4f3"
+github "LoopKit/G4ShareSpy" "3b749bc7f6323ad8303af6c755ba9b5649eff816"
+github "LoopKit/LoopKit" "953b58e617379354b89ea33e0fd8f220ccc2d366"
+github "LoopKit/MKRingProgressView" "f548a5c64832be2d37d7c91b5800e284887a2a0a"
+github "LoopKit/dexcom-share-client-swift" "146cccfe4eba5f536487777a72e0e47834fff64e"
 github "i-schuetz/SwiftCharts" "0.6.5"
-github "maxkonovalov/MKRingProgressView" "2.2.1"
-github "ps2/rileylink_ios" "e0dc72050510fb8bf7fc85f655b8d24dc4de0097"
+github "ps2/rileylink_ios" "802cc005e3eb10cb5e407586210ceb62a57f8c22"

Common/Base.lproj/Intents.intentdefinition

@@ -7,16 +7,18 @@
 	<key>INIntentDefinitionModelVersion</key>
 	<string>1.0</string>
 	<key>INIntentDefinitionSystemVersion</key>
-	<string>17G65</string>
+	<string>18G87</string>
 	<key>INIntentDefinitionToolsBuildVersion</key>
-	<string>10L232m</string>
+	<string>10G8</string>
 	<key>INIntentDefinitionToolsVersion</key>
-	<string>10.0</string>
+	<string>10.3</string>
 	<key>INIntents</key>
 	<array>
 		<dict>
 			<key>INIntentCategory</key>
 			<string>create</string>
+			<key>INIntentDescription</key>
+			<string>Add a carb entry to Loop</string>
 			<key>INIntentDescriptionID</key>
 			<string>yc02Yq</string>
 			<key>INIntentLastParameterTag</key>

Common/Extensions/GlucoseRangeSchedule.swift

@@ -10,43 +10,17 @@ import HealthKit
 
 
 extension GlucoseRangeSchedule {
-    func overrideEnabledForContext(_ context: Override.Context) -> Bool? {
-        guard let override = override, override.context == context else {
-            guard let value = overrideRanges[context], !value.isZero else {
-                // Unavailable to set
-                return nil
-            }
-
-            return false
-        }
-
-        return override.isActive()
-    }
-
-    var activeOverride: GlucoseRangeSchedule.Override? {
-        guard let override = override, override.isActive() else {
-            return nil
-        }
-
-        return override
-    }
-
-    var activeOverrideContext: GlucoseRangeSchedule.Override.Context? {
-        return activeOverride?.context
+    func minQuantity(at date: Date) -> HKQuantity {
+        return HKQuantity(unit: unit, doubleValue: value(at: date).minValue)
     }
 
-    var configuredOverrideContexts: [GlucoseRangeSchedule.Override.Context] {
-        var contexts: [GlucoseRangeSchedule.Override.Context] = []
-        for (context, range) in overrideRanges where !range.isZero {
-            contexts.append(context)
-        }
-
-        return contexts
+    func maxQuantity(at date: Date) -> HKQuantity {
+        return HKQuantity(unit: unit, doubleValue: value(at: date).maxValue)
     }
 }
 
 
-extension Range where Bound == HKQuantity {
+extension ClosedRange where Bound == HKQuantity {
     func averageValue(for unit: HKUnit) -> Double {
         let minValue = lowerBound.doubleValue(for: unit)
         let maxValue = upperBound.doubleValue(for: unit)

Common/Extensions/HKUnit.swift

@@ -36,15 +36,6 @@ extension HKUnit {
         }
     }
 
-    /// An example value for the "ideal" target
-    var glucoseExampleTargetValue: Double {
-        if self == .milligramsPerDeciliter {
-            return 100
-        } else {
-            return 5.5
-        }
-    }
-
     /// The smallest value expected to be visible on a chart
     var chartableIncrement: Double {
         if self == .milligramsPerDeciliter {

Common/Extensions/NSBundle.swift

@@ -30,11 +30,35 @@ extension Bundle {
         return object(forInfoDictionaryKey: "AppGroupIdentifier") as! String
     }
 
+    var isAppExtension: Bool {
+        return bundleURL.pathExtension == "appex"
+    }
+
     var mainAppUrl: URL? {
         if let mainAppBundleIdentifier = mainAppBundleIdentifier {
             return URL(string: "\(mainAppBundleIdentifier)://")
         } else {
             return nil
         }
     }
+
+    var gitRevision: String? {
+        return object(forInfoDictionaryKey: "com-loopkit-Loop-git-revision") as? String
+    }
+
+    var gitBranch: String? {
+        return object(forInfoDictionaryKey: "com-loopkit-Loop-git-branch") as? String
+    }
+
+    var sourceRoot: String? {
+        return object(forInfoDictionaryKey: "com-loopkit-Loop-srcroot") as? String
+    }
+
+    var buildDateString: String? {
+        return object(forInfoDictionaryKey: "com-loopkit-Loop-build-date") as? String
+    }
+
+    var xcodeVersion: String? {
+        return object(forInfoDictionaryKey: "com-loopkit-Loop-xcode-version") as? String
+    }
 }

Common/Extensions/NSTimeInterval.swift

@@ -22,10 +22,6 @@ extension TimeInterval {
         return TimeInterval(hours: hours)
     }
 
-    static func days(_ days: Double) -> TimeInterval {
-        return TimeInterval(days: days)
-    }
-
     init(minutes: Double) {
         self.init(minutes * 60)
     }
@@ -34,15 +30,12 @@ extension TimeInterval {
         self.init(minutes: hours * 60)
     }
 
-    init(days: Double) {
-        self.init(hours: days * 24)
-    }
-
     var minutes: Double {
         return self / 60.0
     }
 
     var hours: Double {
         return minutes / 60.0
     }
+
 }

Common/Extensions/SampleValue.swift

@@ -11,7 +11,7 @@ import LoopKit
 
 extension Collection where Element == SampleValue {
     /// O(n)
-    var quantityRange: Range<HKQuantity>? {
+    var quantityRange: ClosedRange<HKQuantity>? {
         var lowest: HKQuantity?
         var highest: HKQuantity?
 
@@ -33,6 +33,6 @@ extension Collection where Element == SampleValue {
             return nil
         }
 
-        return l..<h
+        return l...h
     }
 }

Common/Extensions/UIColor+HIG.swift

@@ -13,40 +13,8 @@ extension UIColor {
     // MARK: - HIG colors
     // See: https://developer.apple.com/ios/human-interface-guidelines/visual-design/color/
 
-    static func HIGTealBlueColor() -> UIColor {
-        return UIColor(red: 90 / 255, green: 200 / 255, blue: 250 / 255, alpha: 1)
-    }
-
-    static func HIGYellowColor() -> UIColor {
-        return UIColor(red: 1, green: 204 / 255, blue: 0, alpha: 1)
-    }
-
-    static func HIGOrangeColor() -> UIColor {
-        return UIColor(red: 1, green: 149 / 255, blue: 0 / 255, alpha: 1)
-    }
-
-    static func HIGPinkColor() -> UIColor {
-        return UIColor(red: 1, green: 45 / 255, blue: 85 / 255, alpha: 1)
-    }
-
-    static func HIGBlueColor() -> UIColor {
-        return UIColor(red: 0, green: 122 / 255, blue: 1, alpha: 1)
-    }
-
+    // HIG Green has changed for iOS 13. This is the legacy color.
     static func HIGGreenColor() -> UIColor {
         return UIColor(red: 76 / 255, green: 217 / 255, blue: 100 / 255, alpha: 1)
     }
-
-    static func HIGRedColor() -> UIColor {
-        return UIColor(red: 1, green: 59 / 255, blue: 48 / 255, alpha: 1)
-    }
-
-    static func HIGPurpleColor() -> UIColor {
-        return UIColor(red: 88 / 255, green: 86 / 255, blue: 214 / 255, alpha: 1)
-    }
-
-    static func HIGGrayColor() -> UIColor {
-        return UIColor(red: 142 / 255, green: 143 / 255, blue: 147 / 255, alpha: 1)
-    }
-
 }

Common/Extensions/UIColor.swift

@@ -10,21 +10,57 @@ import UIKit
 
 
 extension UIColor {
-    @nonobjc static var tintColor: UIColor? = nil
+    @nonobjc static let secondaryLabelColor: UIColor = {
+        if #available(iOSApplicationExtension 13.0, iOS 13.0, *) {
+            return UIColor.secondaryLabel
+        } else {
+            return UIColor.systemGray
+        }
+    }()
 
-    @nonobjc static let secondaryLabelColor = UIColor.HIGGrayColor()
+    @nonobjc static let cellBackgroundColor: UIColor = {
+        if #available(iOSApplicationExtension 13.0, iOS 13.0, *) {
+            return .secondarySystemBackground
+        } else {
+            return UIColor(white: 239 / 255, alpha: 1)
+        }
+    }()
 
-    @nonobjc static let cellBackgroundColor = UIColor(white: 239 / 255, alpha: 1)
+    @nonobjc static let IOBTintColor = UIColor.systemOrange
 
-    @nonobjc static let IOBTintColor = UIColor.HIGOrangeColor()
+    @nonobjc static let COBTintColor: UIColor = {
+        if #available(iOSApplicationExtension 13.0, iOS 13.0, *) {
+            return UIColor(dynamicProvider: { (traitCollection) in
+                // If we're in accessibility mode, return the system color
+                guard case .normal = traitCollection.accessibilityContrast else {
+                    return .systemGreen
+                }
 
-    @nonobjc static let COBTintColor = UIColor(red: 99 / 255, green: 218 / 255, blue: 56 / 255, alpha: 1)
+                switch traitCollection.userInterfaceStyle {
+                case .unspecified, .light:
+                    return UIColor(red: 99 / 255, green: 218 / 255, blue: 56 / 255, alpha: 1)
+                case .dark:
+                    return UIColor(red: 89 / 255, green: 228 / 255, blue: 51 / 255, alpha: 1)
+                @unknown default:
+                    return UIColor(red: 99 / 255, green: 218 / 255, blue: 56 / 255, alpha: 1)
+                }
+            })
+        } else {
+            return UIColor(red: 99 / 255, green: 218 / 255, blue: 56 / 255, alpha: 1)
+        }
+    }()
 
-    @nonobjc static let agingColor = UIColor.HIGYellowColor()
+    @nonobjc static let agingColor = UIColor.systemYellow
 
-    @nonobjc static let staleColor = UIColor.HIGRedColor()
+    @nonobjc static let staleColor = UIColor.systemRed
 
-    @nonobjc static let unknownColor = UIColor(red: 198 / 255, green: 199 / 255, blue: 201 / 255, alpha: 1)
+    @nonobjc static let unknownColor: UIColor = {
+        if #available(iOSApplicationExtension 13.0, iOS 13.0, *) {
+            return .systemGray4
+        } else {
+            return UIColor(red: 198 / 255, green: 199 / 255, blue: 201 / 255, alpha: 1)
+        }
+    }()
 
-    static let delete = UIColor.HIGRedColor()
+    static let delete = UIColor.systemRed
 }

Common/FeatureFlags.swift

@@ -0,0 +1,25 @@
+//
+//  FeatureFlags.swift
+//  Loop
+//
+//  Created by Michael Pangburn on 5/19/19.
+//  Copyright © 2019 LoopKit Authors. All rights reserved.
+//
+
+import Foundation
+
+
+let FeatureFlags = FeatureFlagConfiguration()
+
+struct FeatureFlagConfiguration: Decodable {
+    let sensitivityOverridesEnabled: Bool
+
+    fileprivate init() {
+        // Swift compiler config is inverse, since the default state is enabled.
+        #if FEATURE_OVERRIDES_DISABLED
+        self.sensitivityOverridesEnabled = false
+        #else
+        self.sensitivityOverridesEnabled = true
+        #endif
+    }
+}