Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To restore String#normalize when deno ships with ICU #105

Closed
motss opened this issue Mar 28, 2019 · 2 comments
Closed

To restore String#normalize when deno ships with ICU #105

motss opened this issue Mar 28, 2019 · 2 comments
Assignees
@motss
Labels
bug enhancement help wanted

Comments

@motss
Copy link
Owner

motss commented Mar 28, 2019 •
edited
Loading

Related issues:
@motss motss self-assigned this Mar 28, 2019
@motss
Copy link
Owner Author

motss commented Apr 4, 2019

Actually don't even need to wait for the fix on deno, a simple feature detection will do the trick. Even so, older deno won't be able to use String.normalize() to produce expected result.

motss added a commit that referenced this issue Apr 7, 2019
@motss
💥 src: Breaking change for a Deno module, also fix #105
9d1a697
motss added a commit that referenced this issue Apr 7, 2019
@motss
💥 src: Breaking change for a Deno module, also fix #105
faed0ab
@motss motss pinned this issue Apr 7, 2019
@motss
Copy link
Owner Author

motss commented Apr 7, 2019

Fixed in faed0ab

@motss motss closed this as completed Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@motss motss

Labels
bug enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@motss