fix: replace banned TypeScript type {} with React.PropsWithChildren#3546
Merged
mattgperry merged 1 commit intomotiondivision:mainfrom Feb 17, 2026
Merged
Conversation
…hChildren
Replace the deprecated {} type with React.PropsWithChildren for the List component props type. This resolves the @typescript-eslint/ban-types lint error.
The {} type is discouraged because it means "any non-nullish value" rather than "empty object". React.PropsWithChildren correctly expresses that the component accepts children.
veeceey
force-pushed
the
fix/typescript-ban-types-issue
branch
from
68ea580 to
ae4c6c6
Compare
Collaborator
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TypeScript lint error by replacing the banned type {} with React.PropsWithChildren.
Summary
TypeScript's @typescript-eslint/ban-types rule flags {} as a banned type. This PR replaces it with the more specific React.PropsWithChildren type.
Changes
Test Plan