feat: scroll page when Reorder container does not have overflow auto or scroll#3508
Merged
mattgperry merged 1 commit intomotiondivision:mainfrom Feb 2, 2026
Merged
Conversation
d918b46 to
547d93e
Compare
Contributor
Author
|
Hey @mattgperry, sorry for the direct ping. When you have a moment, would you be able to take a look at this PR? It's my first time contributing, so I'd really appreciate any feedback in case I missed something. I'm happy to make adjustments if needed to get this merged. LMK! Thanks a lot for your time! |
Collaborator
|
Thanks for the PR! Next week is maintenance week so I’ll be taking a good look then! |
Collaborator
|
Awesome contribution! Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3469
Summary
elementis eitherdocument.bodyordocument.documentElement, then:innerWidthorinnerHeightbased onaxisscrollXorscrollYbased onaxiswindowinvokingscrollBymethodTest plan
reorder-auto-scrollpassEvidence
Screen.Recording.2026-01-23.at.19.25.14.mov