Fix incorrect type of Reorder.Item component#3363
Closed
m2na7 wants to merge 1 commit intomotiondivision:mainfrom
Closed
Fix incorrect type of Reorder.Item component#3363m2na7 wants to merge 1 commit intomotiondivision:mainfrom
m2na7 wants to merge 1 commit intomotiondivision:mainfrom
Conversation
Merged
Collaborator
|
The tests were failing for this so replacing with #3368 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3359
Problem
There was an issue in the
Reorder.Itemcomponent where using invalid props (e.g., onClick="error") did not trigger TypeScript errors, resulting in reduced type safety compared to motion.div.Solution
I improved the Props interface by making it generic with a
Tagparameter to support dynamic HTML element types.Additionally, I enhanced type inference accuracy by using
HTMLMotionProps<Tag>andDOMMotionComponents, and modified the forwardRef type to use specific HTML element types instead ofany, thereby improving type safety by eliminating the use ofanytypes.