Pull request for issue #1204 #3293
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![google-labs-jules[bot]](https://avatars.githubusercontent.com/in/842251?s=60&v=4){kind=small}
This commit introduces the initial groundwork for the `staggerFrom` feature.
Changes include:
- Added `staggerFrom` to the `AnimationOrchestrationOptions` type definition in `packages/motion-dom/src/animation/types.ts`. This allows `staggerFrom` to be a valid property within transition objects.
- Updated the `animateVariant` function in `packages/framer-motion/src/animation/interfaces/visual-element-variant.ts` to extract the `staggerFrom` prop from transition options.
- Modified the `animateChildren` function in the same file (`visual-element-variant.ts`) to:
- Accept `staggerFrom` as a parameter.
- Prioritize `staggerFrom` for calculating individual child animation delays if it's provided. This implements the "stagger outwards" behavior from a specified index.
- Fall back to the existing `staggerDirection` logic if `staggerFrom` is not defined, maintaining backward compatibility.
- Imported `getOriginIndex` and `StaggerOrigin` from `../utils/stagger.ts` to help resolve string-based `staggerFrom` values like "center", "first", "last".
This is an intermediate step. Next steps based on your feedback involve exploring the possibility of using `delayChildren: stagger()` for a more flexible API, which might alter the final implementation of this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1204