perf: Make getProjectionStyles write instead of return fresh obj #3247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The microbenchmark seems to hint to better performance over `Object.assign`: https://esbench.com/bench/683f2196545f8900a4de2d41
kurtextrem
force-pushed
the
perf/setprojectionstyles
branch
from
5106e04 to
f63100d
Compare
|
Merging into a branch to take a look at these tests |
mattgperry
merged commit 8124175
into
motiondivision:feature/projection-style-perf
1 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack on #3245.
Idea here: #3245 (comment).
This way we save an object allocation, plus can skip the
for..inloop, as we makegetProjectionStyleswrite to the target node styles directly.The types are a bit hacky here, but that was the least invasive fix I could think of (without duplicating all the logic).