Add motionValue prop #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvh
approved these changes
Nov 26, 2018
src/hooks/use-posed-values.ts
Outdated
| { onPoseComplete, pose = "default", motionValues, ...props }: MotionProps, | ||
| ref: RefObject<Element> | ||
| ): [MotionValueMap, Partial<MotionProps>] => { | ||
| const values: MotionValueMap = useRef(new Map()).current |
src/hooks/use-posed-values.ts
Outdated
| Object.keys(motionValues).forEach(key => { | ||
| const motionValue = motionValues[key] | ||
|
|
||
| if (motionValue instanceof MotionValue) { |
Contributor
There was a problem hiding this comment.
We should make a habit out of using isMotionValue For this
This was referenced Jan 5, 2026
This was referenced Jan 21, 2026
Closed
This was referenced Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing this pattern:
To:
This will allow us to more strongly type this kind of attribute without whitelisting, and also remove the presumption that this kind of thing is possible: