Skip to content

🐛 Fix disabled prop not being passed to input #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

🐛 Fix disabled prop not being passed to input #35

wants to merge 1 commit into from

Conversation

@a-tokyo
Copy link

@a-tokyo a-tokyo commented Oct 19, 2020 •
edited
Loading

Description:

  • 🐛 Fix disabled prop not being passed to input

Notes:

  • This PR is a bugfix, so it should be merged to v2 BEFORE being pulled to v3 🚀

Closes #34

@asabhaney asabhaney mentioned this pull request Oct 21, 2020
Merged
15 tasks
@a-tokyo
Copy link
Author

a-tokyo commented Feb 25, 2021

Can we land this in version 2 maybe? 🤔

@asabhaney
Copy link
Member

asabhaney commented Mar 10, 2021

Closing via 286f666

@asabhaney asabhaney closed this Mar 10, 2021
@asabhaney
Copy link
Member

asabhaney commented Mar 10, 2021

@a-tokyo just released 3.0.0-alpha.1. You can now pass disabled through the prop inputProps:

<Files inputProps={{ disabled: true }} />

@a-tokyo
Copy link
Author

a-tokyo commented Mar 10, 2021

Thanks!

@a-tokyo a-tokyo deleted the patch-1 branch March 10, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Input can't be disabled

2 participants

@a-tokyo @asabhaney