feat(lib/main): separate _npmInstall method into _getNpmInstallCommand and _packageInstall#580
Merged
DeviaVir merged 1 commit intomotdotla:masterfrom Oct 27, 2021
Conversation
…mand` and `_packageInstall` Separate `_npmInstall` method into two parts. * Get the command string (`_getNpmInstallCommand`) * Execute the command (`_packageInstall`) (Prepare for "Support for yarn motdotla#579".)
abetomo
changed the title
_npmInstall method into _getNpmInstallCommand and _packageInstall…_npmInstall method into _getNpmInstallCommand and _packageInstall
DeviaVir
approved these changes
Oct 27, 2021
Collaborator
DeviaVir
left a comment
DeviaVir
left a comment
There was a problem hiding this comment.
That was quick, nice work.
abetomo
deleted the
feature/separate_npmInstall_method_into_getNpmInstallCommand_and_packageInstall
branch
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate
_npmInstallmethod into two parts._getNpmInstallCommand)_packageInstall)(Prepare for "Support for yarn #579".
I will be adding
_getYarnInstallCommandmethod.)