Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(_uploadExisting): fix function update errors #575

Merged

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Sep 24, 2021

Immediately after updating the settings, Configuration.LastUpdateStatus is InProgress.
If you update the code in that state, you will get an error.
You need to update the code after the Configuration.LastUpdateStatus becomes Successful.

I've fixed it to wait until it becomes Successful.

fixes #573

Immediately after updating the settings, `Configuration.LastUpdateStatus` is `InProgress`.
If you update the code in that state, you will get an error.
You need to update the code after the `Configuration.LastUpdateStatus` becomes `Successful`.

I've fixed it to wait until it becomes `Successful`.
@abetomo abetomo force-pushed the feature/fix_function_update_errors branch from 15f73cb to 9ce0d61 Compare September 24, 2021 06:29
@DeviaVir DeviaVir merged commit 87580cb into motdotla:master Sep 24, 2021
@abetomo abetomo deleted the feature/fix_function_update_errors branch September 25, 2021 00:23
@abetomo
Copy link
Contributor Author

abetomo commented Sep 25, 2021

Thank you for the merge.

@kgfelix
Copy link

kgfelix commented Sep 28, 2021

Hi, do we have a date to launch a new release with this fix?

@DeviaVir
Copy link
Collaborator

https://github.com/motdotla/node-lambda/releases/tag/0.20.0

@kgfelix
Copy link

kgfelix commented Sep 28, 2021

is working fine, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lambda deployment not working
3 participants