Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix npm install test failing in some cases #569

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Jul 30, 2021

If you copy only part of node_modules, npm install may behave the same as npm ci.
This sometimes causes tests that check for identical timestamps to fail.

assert.equal(beforeAwsSdkStat.ctimeMs, afterAwsSdkStat.ctimeMs)

If you copy only part of node_modules, `npm install` may behave the same as `npm ci`.
This sometimes causes tests that check for identical timestamps to fail.

```js
assert.equal(beforeAwsSdkStat.ctimeMs, afterAwsSdkStat.ctimeMs)
```
@DeviaVir DeviaVir merged commit 07112be into motdotla:master Jul 30, 2021
@abetomo abetomo deleted the fix_tests branch July 31, 2021 01:25
@abetomo
Copy link
Contributor Author

abetomo commented Jul 31, 2021

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants