Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value of StartingPosition #467

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Oct 23, 2018

In the SQS event, since the value of StartingPosition is unnecessary, it returns null.

fixes #466

In the SQS event, since the value of StartingPosition is unnecessary,
it returns null.
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@DeviaVir DeviaVir merged commit b890e58 into motdotla:master Oct 23, 2018
@abetomo abetomo deleted the supports_sqs_events branch October 23, 2018 08:31
@sandinmyjoints
Copy link

@abetomo Can you do a new release so this fix can go out?

@abetomo
Copy link
Contributor Author

abetomo commented Nov 15, 2018

@DeviaVir Since I will create a PR, could you please release?

@abetomo abetomo mentioned this pull request Nov 15, 2018
@abetomo
Copy link
Contributor Author

abetomo commented Nov 16, 2018

@DeviaVir Thank you!

@sandinmyjoints 0.13.0 has been released!

@sandinmyjoints
Copy link

sandinmyjoints commented Nov 16, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQS event source fails with 'StartingPosition is not valid for SQS event sources'
3 participants