Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring lib/main.js #398

Merged
merged 4 commits into from
Dec 14, 2017
Merged

Refactoring lib/main.js #398

merged 4 commits into from
Dec 14, 2017

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Dec 14, 2017

I removed unnecessary resolve and reject.

DeviaVir
DeviaVir approved these changes Dec 14, 2017
View reviewed changes
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DeviaVir DeviaVir merged commit 8c7c283 into motdotla:master Dec 14, 2017
@abetomo abetomo deleted the clean_main.js_promise_chain branch December 15, 2017 01:02
@DeviaVir DeviaVir mentioned this pull request Jan 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abetomo @DeviaVir