Skip to content

Fix to deprecated the configFile option in the pacakage command#344

Merged
DeviaVir merged 1 commit intomotdotla:masterfrom
abetomo:fix_configfile_deprecated_in_package
Jul 5, 2017
Merged

Fix to deprecated the configFile option in the pacakage command#344
DeviaVir merged 1 commit intomotdotla:masterfrom
abetomo:fix_configfile_deprecated_in_package

Conversation

@abetomo
Copy link
Contributor

@abetomo abetomo commented Jul 5, 2017

Even if you specify it in the current specification, nothing has any effect.
Therefore, I thought that it might be good to abolish it, but what do you think?

Since sudden deletion has a big influence, we have issued a warning once.

Relation: #246

Even if you specify it in the current specification, nothing has any
effect.
Therefore, I thought that it might be good to abolish it, but how about
you?

Since sudden deletion has a big influence, we have issued a warning
once.
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 sounds good to me, but looks like we'll have to cut another release soon so we have this deployed before actually removing it.

@DeviaVir DeviaVir merged commit 09c2cd8 into motdotla:master Jul 5, 2017
DeviaVir added a commit that referenced this pull request Jul 5, 2017
- Fix to deprecated the `configFile` option in the `pacakage` command
[#344](#344)

- Fix to set boolean in params.Publish
[#346](#346)
@DeviaVir DeviaVir mentioned this pull request Jul 5, 2017
DeviaVir added a commit that referenced this pull request Jul 5, 2017
- Fix to deprecated the `configFile` option in the `pacakage` command
[#344](#344)

- Fix to set boolean in params.Publish
[#346](#346)
@abetomo
Copy link
Contributor Author

abetomo commented Jul 6, 2017

Thank you!

@abetomo abetomo deleted the fix_configfile_deprecated_in_package branch July 6, 2017 01:04
@monsonjeremy
Copy link

@abetomo I'm curious why this option was removed, and what users who use only the package command should do? I do not deploy with the deploy command but rather a custom shell script. Is there anyway to include the environment variables in the package command?

@abetomo
Copy link
Contributor Author

abetomo commented Feb 11, 2020

@monsonjeremy The package option creates a zip file to deploy to Lambda.
You do not need to include environment variables in the zip file.

Environment variables are set from the API or web console.

Previously, there was no way to set environment variables in Lambda, so I included it in my code when creating the zip file.
This option is for that.
This option has been removed now that you can set environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants