Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring _archive #338

Merged
merged 7 commits into from
Jun 28, 2017
Merged

Refactoring _archive #338

merged 7 commits into from
Jun 28, 2017

Commits on Jun 28, 2017

  1. Refactoring _readArchive 

    Modify that _readArchive returns Promise
    @abetomo
    abetomo committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    a5ea679 View commit details
    Browse the repository at this point in the history

  2. Refactoring _archivePrebuilt 

    Modify that _archivePrebuilt returns Promise
    @abetomo
    abetomo committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    93ce5a7 View commit details
    Browse the repository at this point in the history

  3. Refactoring _buildAndArchive

    @abetomo
    abetomo committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    62df54b View commit details
    Browse the repository at this point in the history

  4. Refactoring _archive 

    Modify that _archive returns Promise
    @abetomo
    abetomo committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    ee1d5ef View commit details
    Browse the repository at this point in the history

  5. Replace var with const of package

    @abetomo
    abetomo committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    9a38d09 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary else 

    The condition was reversed.
    @abetomo
    abetomo committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    7615538 View commit details
    Browse the repository at this point in the history

  7. Revert to the previous writing style 

    That is simpler
    @abetomo
    abetomo committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    f6b1d9d View commit details
    Browse the repository at this point in the history