Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored: JavaScript Standard Style #292

Merged
merged 6 commits into from
May 23, 2017
Merged

Refactored: JavaScript Standard Style #292

merged 6 commits into from
May 23, 2017

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented May 23, 2017

  • Add space and format the code
  • Fix using let
  • Fix using strings for single quotes

abetomo and others added 6 commits May 19, 2017 12:57
@abetomo
Fix to use '===' instead of '==' (Including similar modifications)
53525bb
@abetomo
Merge branch 'master' into refactor_javascript_standard_style
2660943
@abetomo
Fix using strings for single quotes
1b49056
@abetomo
Fix using let
b3971cf 
Fix for not being careful with `VARIABLE is already defined`
in JavaScript Standard Style
@abetomo
Add space and format the code
5a04481 
Fix to prevent the message like the following from being displayed
- Missing space before function parentheses.
- Missing space before opening brace.
@abetomo
Merge remote-tracking branch 'upstream/master' into refactor_javascri…
341cf22 
…pt_standard_style_20170522
DeviaVir
DeviaVir approved these changes May 23, 2017
View reviewed changes
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES6 here we go 👍

@DeviaVir DeviaVir merged commit 86949dd into motdotla:master May 23, 2017
@abetomo abetomo deleted the refactor_javascript_standard_style_20170522 branch May 24, 2017 01:06
@DeviaVir DeviaVir mentioned this pull request Jun 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abetomo @DeviaVir