Merged
Conversation
Because Node.js 4.3 sometimes truncate on the way if the result size is large
Because the value changes on Windows and Linux.
Because it is not executed unless you explicitly specify the node command on Windows in case of executing in unit test.
I divided files
DeviaVir
approved these changes
May 17, 2017
Collaborator
DeviaVir
left a comment
There was a problem hiding this comment.
👍 that's a nice fix to have. I wonder about the http://docs.aws.amazon.com/lambda/latest/dg/nodejs-prog-model-context.html#nodejs-prog-model-context-properties callbackWaitsForEmptyEventLoop, should we support it?
Contributor
Author
|
I have not used Lambda with |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resultis presentbin/node-lambdatest