Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fs.exists deprecated #250

Merged
merged 2 commits into from
Apr 29, 2017
Merged

Fix fs.exists deprecated #250

merged 2 commits into from
Apr 29, 2017

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Apr 27, 2017

Fixed as fs.exists was deprecated.
https://nodejs.org/api/fs.html#fs_fs_exists_path_callback

I added a test when the command failed.

DeviaVir
DeviaVir approved these changes Apr 29, 2017
View reviewed changes
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DeviaVir DeviaVir merged commit 1aeae22 into motdotla:master Apr 29, 2017
@abetomo abetomo deleted the fix_fs_exists_deprecated branch May 1, 2017 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abetomo @DeviaVir