Set http timeout to 30 mins. #240
Conversation
DeviaVir
left a comment
There was a problem hiding this comment.
Is 30 mins the max allowed, or an arbitrary number?
Would you mind adding tests for your changes?
Thanks for your contribution!
|
It's just an arbitrary number. There is no limit from amazon. I'm not sure what the additional tests would be? This PR is not expositing any additional functionality. |
|
@rc1 I was thinking about two tests, one to see if |
|
To clarify, I've not added the retry functionality. It's doing that already. I'm am just logging the event to the console. Being honest, I was just playing with a couple of free hours at home. I'd love to dig into the testing and figure it out... but I won't have time it the moment. Feel free to close. |
|
@rc1 apologies, it was not my intention to over-complicate things or to make this repo seem unreachable. I definitely want this change in as it makes |
|
@DeviaVir no apologies needed. It is a bit lame on my part. Ingoring this PR, it would be helpful to have either |
By default aws only allows the http request 2 minutes to upload. This PR increases the limit to 30 minutes. It will also report when a request is being retried and including the reason why.
I was trying to upload 8megs at home. It was taking 8 minutes to report a fail. This was because it uploads for 2 mins, waiting for 1 min and attempts twice more.
Thanks.