Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use fs object #236

Merged
merged 2 commits into from
Apr 20, 2017
Merged

Fix use fs object #236

merged 2 commits into from
Apr 20, 2017

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Apr 20, 2017

No description provided.

DeviaVir
DeviaVir approved these changes Apr 20, 2017
View reviewed changes
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think this is a great change, does it affect Windows support at all, or is rsync/zip still in the way there?

@DeviaVir DeviaVir merged commit 7b375a6 into motdotla:master Apr 20, 2017
@abetomo
Copy link
Contributor Author

abetomo commented Apr 20, 2017

I was not planning to fix rsync/zip.
I will try to challenge it to support Windows.

@DeviaVir
Copy link
Collaborator

@abetomo oh no worries, if you happen to find a way to support it, that would be nice, but not a must-have fix or anything.

@abetomo abetomo deleted the fix_use_fs_object branch April 20, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abetomo @DeviaVir