Skip to content

Clean deploy function #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeviaVir merged 4 commits into from
Apr 6, 2017
Merged

Clean deploy function #220

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be4e365
Clean unnecessary `else`
abetomo Apr 6, 2017
9f0a71a
Add a semicolon
abetomo Apr 6, 2017
75d8d1e
Add comment
abetomo Apr 6, 2017
32c6b67
Fix commit
abetomo Apr 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 28 additions & 26 deletions lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,7 @@ Lambda.prototype.deploy = function (program) {
'FunctionName': params.FunctionName
}, function (err) {
if (err) {
// Function does not exist
return _this._uploadNew(lambda, params, function(err, results) {
if (err) {
throw err;
Expand All @@ -609,34 +610,35 @@ Lambda.prototype.deploy = function (program) {
cb(null, results);
});
});
} else {
_this._listEventSourceMappings(lambda, {
'FunctionName': params.FunctionName
}, function(err, existingEventSourceList) {
if (err) {
throw err;
}

// Function exists
_this._listEventSourceMappings(lambda, {
'FunctionName': params.FunctionName
}, function(err, existingEventSourceList) {
if (err) {
throw err;
}
return async.parallel([
function(_callback) {
_this._uploadExisting(lambda, params, function(err, results) {
if (err) {
throw err;
}
console.log('=> Zip file(s) done uploading. Results follow: ');
console.log(results);
_callback(err, results);
});
},
function(_callback) {
_this._updateEventSources(lambda, params.FunctionName, existingEventSourceList, eventSourceList, function(err, results) {
_callback(err, results);
});
}
return async.parallel([
function(_callback) {
_this._uploadExisting(lambda, params, function(err, results) {
if (err) {
throw err;
}
console.log('=> Zip file(s) done uploading. Results follow: ');
console.log(results);
_callback(err, results);
})
},
function(_callback) {
_this._updateEventSources(lambda, params.FunctionName, existingEventSourceList, eventSourceList, function(err, results) {
_callback(err, results)
})
}
], function(err, results) {
cb(err, results);
});
], function(err, results) {
cb(err, results);
});
}
});
});
}, function (err, results) {
if (err) {
Expand Down