Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean unnecessary else #217

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Clean unnecessary else #217

merged 1 commit into from
Apr 6, 2017

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Apr 5, 2017

When an error, processing is terminated with throw

@abetomo
Clean unnecessary else
ffd0472 
When an error, processing is terminated with throw
DeviaVir
DeviaVir approved these changes Apr 6, 2017
View reviewed changes
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch

@DeviaVir DeviaVir merged commit b02e16c into motdotla:master Apr 6, 2017
@abetomo abetomo deleted the clean_throw_else branch April 6, 2017 10:20
@DeviaVir DeviaVir mentioned this pull request Apr 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abetomo @DeviaVir