Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about it if you have the option to specify the zip file? #199

Merged
merged 2 commits into from
Mar 27, 2017

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Mar 24, 2017

I am very happy if it becomes possible to pass the zip file already created when deploying like this difference.

@abetomo
Copy link
Contributor Author

abetomo commented Mar 24, 2017

Failure of the test seems to be irrelevant to this fix, so we fixed it in a different branch
#198

Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, a handy addition! Thank you so much.

@DeviaVir DeviaVir closed this Mar 27, 2017
@DeviaVir DeviaVir reopened this Mar 27, 2017
@DeviaVir DeviaVir merged commit 42cac04 into motdotla:master Mar 27, 2017
@DeviaVir DeviaVir mentioned this pull request Mar 27, 2017
@DeviaVir
Copy link
Collaborator

This change is now live and published to NPM as 0.8.14.

@abetomo abetomo deleted the feature_created_zipfile_at_deploy branch March 27, 2017 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants