-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version of Node.js supported by AWS Lambda #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just what I came here to find. It looks like the CLI help text needs to be updated as well for this to be totally good though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'd love to see this land w/ a release pretty soon. :)
AWS Lambda now supports Node.js 6.10 and Node.js 4.3.
AWS Lambda now supports Node.js 6.10 and Node.js 4.3
Thank you. |
Failure of the test seems to be irrelevant to this fix, so we fixed it in a different branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested.
Hmm.. @abetomo I still get problems when deploying... Lambda returns node4.3...
|
@bluepeter In that case it will not be nodejs6.10 unless the #200 fix is also included. |
(It appears it will just update |
Thank you. The idea was not extended to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks -- again -- for taking the time to add this. 👍
This change is now live and published to NPM as |
https://aws.amazon.com/jp/about-aws/whats-new/2017/03/aws-lambda-supports-node-js-6-10/
http://docs.aws.amazon.com/lambda/latest/dg/current-supported-versions.html