Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version of Node.js supported by AWS Lambda #197

Merged
merged 3 commits into from
Mar 27, 2017

Conversation

Copy link

@ryanmt ryanmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just what I came here to find. It looks like the CLI help text needs to be updated as well for this to be totally good though.

Copy link

@ryanmt ryanmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd love to see this land w/ a release pretty soon. :)

AWS Lambda now supports Node.js 6.10 and Node.js 4.3.
AWS Lambda now supports Node.js 6.10 and Node.js 4.3
@abetomo
Copy link
Contributor Author

abetomo commented Mar 23, 2017

Thank you.
I fixed it, is there a problem?
Should I also fix .travis.yml?

@abetomo
Copy link
Contributor Author

abetomo commented Mar 24, 2017

Failure of the test seems to be irrelevant to this fix, so we fixed it in a different branch
#198

Copy link

@bluepeter bluepeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested.

@bluepeter
Copy link

Hmm.. @abetomo I still get problems when deploying... Lambda returns node4.3...

{ FunctionName: 'XXX',
  Code: { ZipFile: <Buffer 50 4b 03 04 14 00 00 00 08 00 92 6d 78 4a 7f 0e da 58 05 01 00 00 53 01 00 00 04 00 1c 00 2e 65 6e 76 55 54 09 00 03 43 b2 d4 58 43 b2 d4 58 75 78 0b ... > },
  Handler: 'index.handler',
  Role: 'arn:aws:iam::XXX',
  Runtime: 'nodejs6.10',
  Description: 'XXX',
  MemorySize: '1024',
  Timeout: '60',
  Publish: false,
  VpcConfig: { SubnetIds: [], SecurityGroupIds: [] },
  Environment: { Variables: {} } }
=> Zip file(s) done uploading. Results follow:
[ { FunctionName: 'XXX',
    FunctionArn: 'arn:aws:lambda:us-east-1:XXXl',
    Runtime: 'nodejs4.3',
    Role: 'arn:aws:iam::XXX',
    Handler: 'index.handler',
    CodeSize: 27902661,
    Description: 'XXX',
    Timeout: 60,
    MemorySize: 1024,
    LastModified: '2017-03-24T05:45:09.137+0000',
    CodeSha256: 'XXX=',
    Version: '$LATEST',
    VpcConfig: { SubnetIds: [], SecurityGroupIds: [], VpcId: '' },
    KMSKeyArn: null } ]```

@abetomo
Copy link
Contributor Author

abetomo commented Mar 24, 2017

@bluepeter
Are you deploying to the function already created with nodejs4.3?

In that case it will not be nodejs6.10 unless the #200 fix is also included.

@bluepeter
Copy link

@abetomo yeah, that's the problem. Do you know if in #200 the update will update across, e.g., all versions/aliases of the function, or only in the $latest version?

@bluepeter
Copy link

(It appears it will just update $latest: "If you are using the versioning feature, note this API will always update the $LATEST version of your Lambda function.")

@abetomo
Copy link
Contributor Author

abetomo commented Mar 24, 2017

Thank you. The idea was not extended to version.
As you pointed out, it seems that only $latest will be updated.

Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- again -- for taking the time to add this. 👍

@DeviaVir DeviaVir merged commit 80564ea into motdotla:master Mar 27, 2017
@DeviaVir DeviaVir mentioned this pull request Mar 27, 2017
@DeviaVir
Copy link
Collaborator

This change is now live and published to NPM as 0.8.14.

@abetomo abetomo deleted the fix_nodejs_v610 branch March 27, 2017 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants