Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set NodeJS v14 as the oldest supported engine version #811

Closed
wants to merge 1 commit into from
Closed

fix: Set NodeJS v14 as the oldest supported engine version #811

wants to merge 1 commit into from

Conversation

lekspyl
Copy link

@lekspyl lekspyl commented Feb 13, 2024

dotenv v16.4.3 can't be used with Node 12 because the change introduced in the PR #805 contains an optional chaining operator that is supported by NodeJS starting from v14, thus running it with v12 engine version results in the

  if (options?.encoding) {
              ^
SyntaxError: Unexpected token '.'

exception.

Considering that Node v12 has reached EOL I assume it's better to set v14 as the oldest version constraint.

dotenv v16.4.3 can't be used with Node 12 because the change introduced in the PR #805 contains an optional chaining operator that is supported by NodeJS starting from v14, thus running it with v12 engine version results in the
```js
  if (options?.encoding) {
              ^
SyntaxError: Unexpected token '.'
```
exception.

Considering that Node v12 has reached EOL I assume it's better to set v14 as the oldest version constraint.
@motdotla
Copy link
Owner

maybe, but it would be nice to still support older versions. many people still run node 12 in production. @thanosd would you like to take a crack at modify that to support node 12?

@motdotla
Copy link
Owner

tests passed here for 12. #812

and released under v16.4.4.

thank you for contributing this @lekspyl. i'm going to close though.

@motdotla motdotla closed this Feb 13, 2024
@thanosd
Copy link
Contributor

thanosd commented Feb 13, 2024

You beat me to it.

@lekspyl lekspyl deleted the lp/node-version-align branch February 13, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants