-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimal README to docs directory #125
Conversation
It looks like there are some extra commits in the PR. Could you rebase on latest master so it just has the one relevant commit? Thanks! |
I've never rebased anything before. How do you rebase something that is already on a master branch? |
In your clone you want to do something like this at a shell of some kind
Where |
Ok, so I did that and got this; not sure how to interpret it though:
When I do git status, it says:
|
|
It looks like what happened was that your fork's remote master may not have been up-to-date with the upstream (the mostjs/core repo) when the PR was opened. Hard to tell for sure, though, since there's also a merge commit (a059130) after the change to the README ... not clear where that came from. In any event, thanks for giving it a go. If it doesn't end up looking right after the rebase and force push, we have a couple other options. For example, either you or one of us can create a new branch from up-to-date master and cherry-pick the one relevant commit (0b1434d) to it, and open a new PR. |
Commit log should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor requests, otherwise LGTM
docs/README.md
Outdated
@@ -0,0 +1,3 @@ | |||
## Almost there... | |||
|
|||
Documentation for Most.js can be found at [mostcore.readthedocs.io](http://mostcore.readthedocs.io). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small requests: Let's change "Most.js" to "@most/core
", and make the link https
. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Just a convenient link to the readthedocs site.