cli: add volume to docker-compose.yml

mostafa-asg · May 8, 2018 · 7bdb452 · 7bdb452
1 parent 6195c19
commit 7bdb452
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 13 deletions.
diff --git a/cli/packages/prisma-cli-core/src/commands/init/__snapshots__/index.test.ts.snap b/cli/packages/prisma-cli-core/src/commands/init/__snapshots__/index.test.ts.snap
@@ -22,12 +22,16 @@ services:
           default:
             connector: mysql
             migrations: true
-            host: db
+            host: mysql
             port: 3306
-  db:
+  mysql:
     restart: always
     environment:
       MYSQL_ROOT_PASSWORD: prisma
+    volumes:
+      - db-persistence:/var/lib/mysql
+volumes:
+  mysql:
 ",
   "prisma.yml": "endpoint: http://localhost:4466
 datamodel: datamodel.graphql",

diff --git a/cli/packages/prisma-cli-core/src/utils/EndpointDialog.ts b/cli/packages/prisma-cli-core/src/utils/EndpointDialog.ts
@@ -66,19 +66,27 @@ const defaultPorts = {
 
 const databaseServiceDefinitions = {
   postgres: `
-  db:
+  postgres:
     image: postgres
     restart: always
     environment:
       POSTGRES_USER: prisma
       POSTGRES_PASSWORD: prisma
+    volumes:
+      - postgres:/var/lib/postgresql/data
+volumes:
+  postgres:
 `,
   mysql: `
-  db:
+  mysql:
     image: mysql:5.7
     restart: always
     environment:
       MYSQL_ROOT_PASSWORD: prisma
+    volumes:
+      - db-persistence:/var/lib/mysql
+volumes:
+  mysql:
 `,
 }
 
@@ -224,7 +232,7 @@ export class EndpointDialog {
           user: type === 'mysql' ? 'root' : 'prisma',
           password: 'prisma',
           type,
-          host: 'db',
+          host: type === 'mysql' ? 'mysql' : 'postgres',
           port: defaultPorts[type],
         }
         dockerComposeYml += this.printDatabaseConfig(credentials)

diff --git a/cli/packages/prisma-cli-core/src/utils/__snapshots__/EndpointDialog.test.ts.snap b/cli/packages/prisma-cli-core/src/utils/__snapshots__/EndpointDialog.test.ts.snap
@@ -19,7 +19,7 @@ Object {
       "workspaceSlug": undefined,
     },
     "database": Object {
-      "host": "db",
+      "host": "mysql",
       "password": "prisma",
       "port": 3306,
       "type": "mysql",
@@ -45,12 +45,16 @@ services:
           default:
             connector: mysql
             migrations: true
-            host: db
+            host: mysql
             port: 3306
-  db:
+  mysql:
     restart: always
     environment:
       MYSQL_ROOT_PASSWORD: prisma
+    volumes:
+      - db-persistence:/var/lib/mysql
+volumes:
+  mysql:
 ",
     "endpoint": "http://localhost:4466",
     "localClusterRunning": false,
@@ -83,7 +87,7 @@ Object {
       "workspaceSlug": undefined,
     },
     "database": Object {
-      "host": "db",
+      "host": "mysql",
       "password": "prisma",
       "port": 3306,
       "type": "mysql",
@@ -109,12 +113,16 @@ services:
           default:
             connector: mysql
             migrations: true
-            host: db
+            host: mysql
             port: 3306
-  db:
+  mysql:
     restart: always
     environment:
       MYSQL_ROOT_PASSWORD: prisma
+    volumes:
+      - db-persistence:/var/lib/mysql
+volumes:
+  mysql:
 ",
     "endpoint": "http://localhost:4466",
     "localClusterRunning": true,
@@ -150,12 +158,16 @@ services:
           default:
             connector: mysql
             migrations: true
-            host: db
+            host: mysql
             port: 3306
-  db:
+  mysql:
     restart: always
     environment:
       MYSQL_ROOT_PASSWORD: prisma
+    volumes:
+      - db-persistence:/var/lib/mysql
+volumes:
+  mysql:
 ",
   "prisma.yml": "endpoint: http://localhost:4466
 datamodel: datamodel.graphql",