-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GMSO to work with pydantic 2.0 #745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
…implemeted error), all serialization tests fixed
…to be consistent previous version
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 92.81% 92.36% -0.46%
==========================================
Files 66 66
Lines 6862 6860 -2
==========================================
- Hits 6369 6336 -33
- Misses 493 524 +31 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what is the result of removing the JSONHandler
class in gmso.abc.serialization_utils? Is that going to change the ability to use the top.save("top.json") method?
Otherwise, minus just some questions for my understanding this is good to go.
The reason |
Excellent, good to know. I'm about to push fixes to these conflicts with the main branch, then we can get this merged. |
…ic2_compatibility
for more information, see https://pre-commit.ci
…/gmso into pydantic2_compatibility
for more information, see https://pre-commit.ci
…/gmso into pydantic2_compatibility
Pydantic v2 just recently comes out and seem to offer a lot of benefits, but also bring along many breaking changes to our current API. This PR will attempt to update GMSO classes to work with the latest version of pydantic.