Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge conflicts from main #675

Merged
merged 10 commits into from
Jul 21, 2022
Merged

merge conflicts from main #675

merged 10 commits into from
Jul 21, 2022

Conversation

CalCraven
Copy link
Contributor

Merge in updates to main branch.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 20, 2022

This pull request introduces 4 alerts when merging 9f1686d into d95fd5b - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #675 (04b5f08) into develop (d95fd5b) will decrease coverage by 0.00%.
The diff coverage is 89.89%.

@@             Coverage Diff             @@
##           develop     #675      +/-   ##
===========================================
- Coverage    91.22%   91.22%   -0.01%     
===========================================
  Files           63       63              
  Lines         5061     5160      +99     
===========================================
+ Hits          4617     4707      +90     
- Misses         444      453       +9     
Impacted Files Coverage Δ
gmso/core/topology.py 91.37% <78.94%> (-0.58%) ⬇️
gmso/core/atom_type.py 97.36% <80.00%> (+0.18%) ⬆️
gmso/core/parametric_potential.py 92.78% <84.00%> (-3.05%) ⬇️
gmso/core/forcefield.py 96.56% <97.72%> (+0.18%) ⬆️
gmso/utils/misc.py 97.67% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95fd5b...04b5f08. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 20, 2022

This pull request introduces 2 alerts when merging 6ad3819 into d95fd5b - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 20, 2022

This pull request introduces 1 alert when merging e0d8f3e into d95fd5b - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 21, 2022

This pull request introduces 1 alert when merging 04b5f08 into d95fd5b - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

@CalCraven CalCraven merged commit 2970412 into mosdef-hub:develop Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant