-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expected parameters dimensions to PotentialTemplates
#657
Add expected parameters dimensions to PotentialTemplates
#657
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #657 +/- ##
===========================================
+ Coverage 90.66% 90.78% +0.11%
===========================================
Files 57 57
Lines 4661 4719 +58
===========================================
+ Hits 4226 4284 +58
Misses 435 435
Continue to review full report at Codecov.
|
This pull request introduces 1 alert and fixes 1 when merging 288aa51 into 1b8eda1 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request fixes 3 alerts when merging 4d03e4d into 1b8eda1 - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging dd43746 into a6255a4 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks great! only found mistake in the expecting unit of buckingham potential.
This pull request fixes 2 alerts when merging 3b82f3e into a6255a4 - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging ddac316 into 04f2845 - view on LGTM.com fixed alerts:
|
Closes #656.