Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expected parameters dimensions to PotentialTemplates #657

Merged

Conversation

umesh-timalsina
Copy link
Member

Closes #656.

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #657 (ddac316) into develop (04f2845) will increase coverage by 0.11%.
The diff coverage is 98.43%.

@@             Coverage Diff             @@
##           develop     #657      +/-   ##
===========================================
+ Coverage    90.66%   90.78%   +0.11%     
===========================================
  Files           57       57              
  Lines         4661     4719      +58     
===========================================
+ Hits          4226     4284      +58     
  Misses         435      435              
Impacted Files Coverage Δ
gmso/lib/potential_templates.py 95.78% <97.77%> (+1.67%) ⬆️
gmso/core/parametric_potential.py 95.83% <100.00%> (ø)
gmso/exceptions.py 100.00% <100.00%> (ø)
gmso/utils/expression.py 92.63% <100.00%> (+0.37%) ⬆️
gmso/abc/abstract_potential.py 90.27% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f2845...ddac316. Read the comment docs.

@umesh-timalsina umesh-timalsina changed the base branch from main to develop May 11, 2022 20:45
@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 11, 2022

This pull request introduces 1 alert and fixes 1 when merging 288aa51 into 1b8eda1 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 11, 2022

This pull request fixes 3 alerts when merging 4d03e4d into 1b8eda1 - view on LGTM.com

fixed alerts:

  • 3 for Unused import

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 26, 2022

This pull request fixes 2 alerts when merging dd43746 into a6255a4 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

Copy link
Member

@daico007 daico007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks great! only found mistake in the expecting unit of buckingham potential.

gmso/lib/jsons/BuckinghamPotential.json Outdated Show resolved Hide resolved
@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 27, 2022

This pull request fixes 2 alerts when merging 3b82f3e into a6255a4 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 6, 2022

This pull request fixes 2 alerts when merging ddac316 into 04f2845 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Expected Dimensions for PotentialTemplate parameters.
2 participants