Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test on broker.subscribe & broker.unsubscribe function #418

Merged
merged 5 commits into from
Feb 11, 2020

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Feb 8, 2020

  • added tests
  • fixed typings

@gnought gnought added the bug label Feb 8, 2020
@gnought gnought requested a review from mcollina February 8, 2020 14:04
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gnought gnought merged commit 5110824 into moscajs:master Feb 11, 2020
@gnought gnought deleted the hotfix/fix_param_type branch February 11, 2020 02:49
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8c2ed33ffc274ea30f571385297962df5ae6425a-PR-418

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 96.651%

Files with Coverage Reduction New Missed Lines %
lib/handlers/connect.js 2 97.78%
Totals Coverage Status
Change from base Build b3f844c260f5b27106a300ba5ee549b8bbba788c: 0.2%
Covered Lines: 745
Relevant Lines: 762

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8c2ed33ffc274ea30f571385297962df5ae6425a-PR-418

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 96.651%

Files with Coverage Reduction New Missed Lines %
lib/handlers/connect.js 2 97.78%
Totals Coverage Status
Change from base Build b3f844c260f5b27106a300ba5ee549b8bbba788c: 0.2%
Covered Lines: 745
Relevant Lines: 762

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants