Replace findhit-utils with lodash at runtime (fixes #36) #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lib is BSD, but had a runtime dependency on the GPL findhit-utils, meaning any derivitive works need to be GPL. findhit-util is still used as a dev dependency for testing the options behaviour. package.json "files" array has been added to not include the test code in the resulting package so there's no GPL dependant code in the resulting library.
Author
|
Hi @cusspvz , any chance you'd be able to take a look at this PR? |
Member
|
Thanks for your contribute! Landed these changes and published a new patch release, as we haven't added new functionalities. |
Author
|
Brilliant, thank you :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lib is BSD, but had a runtime dependency on the GPL findhit-utils,
meaning any derivitive works need to be GPL.
findhit-util is still used as a dev dependency for testing the options
behaviour.
package.json "files" array has been added to not include the test code
in the resulting package so there's no GPL dependant code in the
resulting library.