Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch delta table not found error #1625

Merged
merged 17 commits into from
Oct 30, 2024
Merged

Conversation

milocress
Copy link
Contributor

when the delta table isn't found, surface this error to the user.

@milocress milocress marked this pull request as ready for review October 29, 2024 18:02
@milocress milocress requested a review from a team as a code owner October 29, 2024 18:02
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test in test_convert_delta_to_json.py please?

@milocress
Copy link
Contributor Author

The docformatter hook runs without error locally, it grates like sandpaper against my soul that this hook would run differently on the server.

@milocress
Copy link
Contributor Author

I think it's cool that docformatter won't tell me which file is incorrect, it's like a fun little scavenger hunt.

Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving from foundry side. please make sure you and jane agree on the unresolved conversation before merging

@milocress milocress merged commit 30ab45d into main Oct 30, 2024
9 checks passed
@milocress milocress deleted the milo/catch-delta-table-not-found branch October 30, 2024 18:29
dakinggg pushed a commit that referenced this pull request Nov 1, 2024
dakinggg pushed a commit that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants