-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the export for onnx script to work with HF models #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
requested review from
vchiley,
abhi-mosaic and
dskhudia
and removed request for
vchiley
April 6, 2023 20:50
dskhudia
approved these changes
Apr 6, 2023
Would the onnx model work with kv caching? It's not returning past_key_values. |
No, I don't think this works with kv caching right now. I think HF has some support for doing this with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1b training on this pr: https://wandb.ai/mosaic-ml/daniel-debug/runs/3rnsjn09?workspace=user-danielking
pytest passes:
========================================================== 145 passed, 3 skipped, 31 xfailed, 352 warnings in 311.60s (0:05:11) ===========================================================