ClipQKV #197
Merged
ClipQKV #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi-mosaic
reviewed
Feb 28, 2023
Co-authored-by: Abhi Venigalla <77638579+abhi-mosaic@users.noreply.github.com>
created issue: https://mosaicml.atlassian.net/browse/RESEARCH-468 |
|
nvm, i misread the output. looks like your added tests are failing |
bmosaicml
approved these changes
Mar 1, 2023
|
yeah they're gpu tests. I need to xfail them on cpu. Forgot to do that... |
bcui19
approved these changes
Mar 1, 2023
vchiley
force-pushed
the
clip_qkv
branch
3 times, most recently
from
1b02a56
to
7b6f3ae
Compare
vchiley
force-pushed
the
clip_qkv
branch
2 times, most recently
from
49392da
to
62d9749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
qk_lnin triton attn variantOn its own, Alibi does not fully solve the stability issue; when clipping is added to qkv, training becomes more stable.
Without Alibi, clipping qkv is still very stable (it just doesn't do as well)
I tried clipping values of
{0.1, 1, 2, 10};{0.1, 1}were too aggressive;{2, 10}are shown. We can see that when the clipping value is higher (10) the network is slightly less stable and gets psuedo-loss spikes from which it recovers gracefully.ClipQKV+Alibi outperforms QKLN
ClipQKV+Alibi has the exact same performance as QKLN+Alibi
