Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nemo Megatron #138

Merged
merged 7 commits into from
Feb 9, 2023
Merged

Update Nemo Megatron #138

merged 7 commits into from
Feb 9, 2023

Conversation

bcui19
Copy link
Contributor

@bcui19 bcui19 commented Feb 9, 2023

This change updates the nemo example as follows (from PR #115):

  • Fixed a bug in the seq command which launched one process too many, failing the job
  • Update to run_name to have an informative default
  • Updating base image to latest nemo image 22.11
  • Added comments better document the setup
  • Moved apt install into the integrations section
  • Updated a few hyper parameters to ensure successful run

Both YAMLs were tested and ran successfully on r7z2 (tested with @bcui19 's pre-processed data stored at s3://mosaicml-internal-checkpoints-shared/brandon/NeMo/)

Also removed linting issues.

lupesko and others added 7 commits February 5, 2023 23:14
This change updates the nemo example as follows:
- Fixed a bug in the seq command which launched one process too many, failing the job
- Update to run_name to have an informative default
- Updating base image to latest nemo image 22.11
- Added comments better document the setup
- Moved apt install into the integrations section
- Updated a few hyper parameters to ensure successful run
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcui19 bcui19 merged commit 3088344 into mosaicml:main Feb 9, 2023
@bcui19 bcui19 mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants