Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Train loss NaN checking callback #2704

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Train loss NaN checking callback #2704

merged 6 commits into from
Nov 9, 2023

Conversation

coryMosaicML
Copy link
Contributor

Add a simple NaN catching callback that will raise an error if a NaN in the train loss is found.

mvpatel2000
mvpatel2000 reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we name NaNMonitor instead to be consistent with other callbacks? otherwise lgtm!

mvpatel2000
mvpatel2000 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!!

CC: @dakinggg we should add this into foundry on next release

@coryMosaicML coryMosaicML merged commit eb7a9cf into mosaicml:dev Nov 9, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coryMosaicML @mvpatel2000 @corystephenson-db