Add vertical segments example page #319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way to define the width of the vertical segments? Ideally I'd like them to be the same width as the bars? |
|
No, there's no such thing at the moment. You can suggest a PR to do that. I would assume that would be done over here: https://github.com/sudodoki/morris.js/blob/e8d84dca099f2428fcbebcb96f7de60135f717fa/lib/morris.bar.coffee#L113. |
|
Any reason why this is not merged yet? Since #297 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case #297 is merged will work on this to provide example page.
Fun fact: 'lib/example.js' in head may cause improper chart render (~3 times wider than needed) after page refresh - probably, has to do with document loading & browser cache.