-
Notifications
You must be signed in to change notification settings - Fork 11
Feat/vault v2 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/vault v2 #59
Conversation
MazyGio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing work! Just requesting one change on the fee math
fdemiramon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it
fdemiramon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it
@codex knowing the following, can you review the codebase
Architecture Understanding
VaultV2 Key Concepts (Validated as Correct)
Adapter Architecture: VaultV2 uses adapters to allocate assets to various markets. Each adapter reports
realAssets()back to the vault.ID-based Caps: Multiple adapters can share the same ID to cap aggregate exposure. Each ID has:
allocation: Current allocated amountabsoluteCap: Fixed maximum allocationrelativeCap: Percentage-based maximum (relative to total assets)effectiveCap:min(absoluteCap, relativeCap * totalAssets)Fee Structure:
TODO
Medium Priority (Optional)
Low Priority (Nice to Have)