Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(vault): use asset instead of underlying #851

Merged
merged 1 commit into from
Jun 8, 2023
Merged

refactor(vault): use asset instead of underlying #851

merged 1 commit into from
Jun 8, 2023

Conversation

Rubilmax
Copy link
Collaborator

@Rubilmax Rubilmax commented Jun 7, 2023 •
edited
Loading

Pull Request

Issue(s) fixed

This pull request:

@Rubilmax Rubilmax marked this pull request as ready for review June 7, 2023 12:43
MerlinEgalite
MerlinEgalite approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

MathisGD
MathisGD approved these changes Jun 8, 2023
View reviewed changes
src/extensions/SupplyVault.sol Show resolved Hide resolved
@Rubilmax Rubilmax merged commit cdc9002 into dev Jun 8, 2023
@Rubilmax Rubilmax deleted the refactor/supply-vault branch June 8, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Tristan22400 Tristan22400 Tristan22400 approved these changes

@makcandrov makcandrov Awaiting requested review from makcandrov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rubilmax @Tristan22400 @MerlinEgalite @pakim249CAL @MathisGD